feat(linter): implement eslint/no-useless-backreference#4096
Closed
Sysix wants to merge 24 commits intooxc-project:mainfrom
Sysix:main
Closed
feat(linter): implement eslint/no-useless-backreference#4096Sysix wants to merge 24 commits intooxc-project:mainfrom Sysix:main
Sysix wants to merge 24 commits intooxc-project:mainfrom
Sysix:main
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Sysix
changed the title
CodSpeed Performance ReportMerging #4096 will not alter performanceComparing Summary
|
Member
Author
|
I encountered problems with nested (negative) look-behinds/aheads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first work on oxc in rust. So please tell me when something can be done better.
I have already some ideas to optimize to code. For that there should me mostly a ToDo in the Code.
Currently on work:
report_invalid_back_reference(s)callThere are also some outcommented test. These only makes more parser work and are (in my opinion) rare.
Please check if they are needed:
eslintmarks them as okRegExpparser #3824 validator?p = '\\1', s = '(a)'; new RegExp(p + s);should fail)Linter Docs:
https://eslint.org/docs/latest/rules/no-useless-backreference